*BSD News Article 92835


Return to BSD News archive

From: borki@rb.xs.use.ch (Reto Burkhalter)
Subject: Re: 2.2.1 and empty-passwords
Message-ID: <zQg03MD4F99aCz4@rb.xs.use.ch>
Date: Wed, 2 Apr 97 07:39:35 CET
Newsgroups: comp.unix.bsd.freebsd.misc
References: <5hovjq$b82@uriah.heep.sax.de>
X-Newsreader: MicroDot 1.12 [REGISTERED 004f99]
Organization: use Communications
Lines: 31
Path: euryale.cc.adfa.oz.au!newshost.carno.net.au!harbinger.cc.monash.edu.au!ns.saard.net!spasun.tpa.com.au!duster.adelaide.on.net!news.ade.connect.com.au!news.mel.connect.com.au!munnari.OZ.AU!news.ecn.uoknor.edu!feed1.news.erols.com!howland.erols.net!blackbush.xlink.net!news-ge.switch.ch!news-zh.switch.ch!dino.active.ch!hp.use.ch!xs!rb.xs.use.ch!not-for-mail
Xref: euryale.cc.adfa.oz.au comp.unix.bsd.freebsd.misc:38487

>> J Wunsch
>> 31.03.1997


> Two people doing wrong... one with a logico, and another one who
> dragged this logico untested onto the 2.2 branch at 23:59. :-(
> 
> Index: /usr/src/usr.bin/login/login.c
> ===================================================================
> RCS file: /home/cvs/src/usr.bin/login/login.c,v
> retrieving revision 1.12.2.2
> retrieving revision 1.12.2.3
> diff -u -u -r1.12.2.2 -r1.12.2.3
> --- login.c   1997/03/25 05:26:29     1.12.2.2
> +++ login.c   1997/03/27 10:06:43     1.12.2.3
> @@ -268,7 +268,7 @@
>                               /* already authenticated */
>                               break;
>                       } else if (pwd->pw_passwd[0] == '\0') {
> -                             if (rootlogin && !rootok) {
> +                             if (!rootlogin || rootok) {
>                                       /* pretend password okay */
>                                       rval = 0;
>                                       goto ttycheck;
> 

I'm not a C freak... What I'm going to do with this? Change
the two lines (the ones with the + and -)?


Reto