Return to BSD News archive
Path: sserve!newshost.anu.edu.au!munnari.oz.au!news.Hawaii.Edu!ames!agate!deraadt From: deraadt@fsa.ca (Theo de Raadt) Newsgroups: comp.os.386bsd.misc Subject: Re: Status on discussed merge between NetBSD and FreeBSD Date: 14 Nov 93 13:11:58 Organization: little lizard city Lines: 71 Message-ID: <DERAADT.93Nov14131158@pain.agate> References: <JKH.93Nov13222001.2@whisker.lotus.ie> <2c60p5$p6v@zip.eecs.umich.edu> <2c61k1$j2p@pdq.coe.montana.edu> <DERAADT.93Nov14120145@pain.agate> <CGI1IM.D1x@kithrup.com> NNTP-Posting-Host: pain.cs.berkeley.edu In-reply-to: sef@kithrup.com's message of Sun, 14 Nov 1993 20:42:07 GMT In article <CGI1IM.D1x@kithrup.com> sef@kithrup.com (Sean Eric Fagan) writes: In article <DERAADT.93Nov14120145@pain.agate> deraadt@fsa.ca (Theo de Raadt) writes: >The claims that attribution has been done correctly are quite false. That's okay, I don't find my name anywhere in the ptrace code I wrote. I also was never asked permission before it was placed for redistribution. This is really funny, Sean. This is a prime example of how we attempt to work with people, and how we provide attribution! You gave the code to Chris, who commited it to the tree. In mail (I guess) you indicated a willingness to work on it more, in the tree. (This is good, we love it when people want to take responsibility for things we don't know much about :-). So, you were given access so you could continue to work on it. From the CVS logs.. it appears you did work on it.. and even commited two more changes! If you did not change the Berkeley copyright header at the top of the file to give yourself credit that's your own fault. In fact, the changes seem sufficiently large enough that you should have given yourself credit (and not the University of California). It looks like you replaced 50% or more of the file! For those who don't know... the file in question is sys/kern/sys_process.c, and it impliments the ptrace() system call used by debuggers. Here's the significant portions of the logs: revision 1.11 date: 1993/09/05 03:53:52; author: sef; state: Exp; lines: +14 -1 Yet more of the ptrace() reorg; now ptrace_setregs() and ptrace_getregs() are present, along with PT_GETREGS and PT_SETREGS ptrace commands. ---------------------------- revision 1.10 date: 1993/09/04 08:46:36; author: sef; state: Exp; lines: +5 -3 ptrace_single_step() and ptrace_set_pc() should return errors if necessary. (Mainly because the SPARC can't easily single step, so it should return EINVAL, and then ptrace() should return that to the user.) ---------------------------- revision 1.9 date: 1993/09/04 05:32:35; author: cgd; state: Exp; lines: +217 -254 better ptrace() support from Sean Eric Fagan <sef@kithrup.com> ---------------------------- Hasn't stopped you guys from distributing it, now has it? Frankly, it doesn't bother me. I wrote the code so people could use it, and because the old code was pretty stupid. No, it has not stopped us from distributing it. Since you commited it to the tree, why should we not use it? By mailing it to Chris in the first place you explicitly gave us permission to use it. [...] or the log comment says, "Imported from NetBSD." That's no more or less than you have done. When NetBSD people do a `cvs commit' we try to do more than this; by crediting the original author. For an example of how we do that, look at revision 1.9 of of the file as displayed above... there are a very large number of commit messages with exactly that format, encompassing a list of contributers all over the world. XXXXX from John Doe <jdoe@foobar.com> If you like, I will change the file header messages to indicate that you deserve credit for the ptrace() rewrite. Really, we like to give credit. <tdr.