*BSD News Article 16741


Return to BSD News archive

Path: sserve!newshost.anu.edu.au!munnari.oz.au!network.ucsd.edu!swrinde!cs.utexas.edu!milano!uudell!obiwan!bob
From: bob@obiwan.uucp (Bob Willcox)
Newsgroups: comp.os.386bsd.bugs
Subject: Re: FWD: new scsi/st.c
Message-ID: <C7zrB8.EnM@obiwan.uucp>
Date: 2 Jun 93 11:16:19 GMT
References: <1993May26.185105.212@coe.montana.edu>
Organization: Bob's Place, Austin TX
Lines: 56

Below is a patch for the scsi/st.c file from Julian Elischer for his
recently posted (by Nate) new SCSI tape device driver.  It fixes a
problem with variable length records on Exabyte tape drives.  Note that
there still seems to be a problem when reading short blocks with this
driver.  Also, I noticed -11 offset for the second two hunks when
installing (with patch).  Seemed to install okay, though.

Bob

------------ beginning of Julian's email/patch ------------
> 
> Julian Elischer wrote:
> > I don't have access to a scsi variable drive at the moment,
> > but could you try trace through the initialisation code to see if
> > it has made that decision, and why?
> 
> Okay, I'll give it a try and let you know the results.
> 
I think I found it..
try the following patch:

julian
p.s. if this works, could you post this fix, as it will definitly
fail on exabytes according to the manual (I have the 8200 docs).

All I can say is:  "oops"

===================================================================
RCS file: RCS/st.c,v
retrieving revision 1.8
diff -r1.8 st.c
2c2
<  * Written by Julian Elischer (julian@tfs.com)
---
>  * Written by Julian Elischer (julian@tfs.com)(now julian@DIALix.oz.au)
570,571c570,576
< 		if((st->blkmin && (st->blkmin == st->blkmax))
< 			|| (st->media_blksiz))
---
> 		/*******************************************************\
> 		* There was once a reason that the tests below were	*
> 		* deemed insufficient, but I can't remember why..	*
> 		* If your drive needs these added to, let me know	*
> 		* and/or add a rogue entry.				*
> 		\*******************************************************/
> 		if(st->blkmin && (st->blkmin == st->blkmax))
573c578
< 		else
---
> 		if(st->blkmin != st->blkmax)
> 

-- 
Bob Willcox                ...!{rutgers|ames}!cs.utexas.edu!uudell!obiwan!bob
Phone: 512 258-4224 (home)
       512 838-3914 (work)