*BSD News Article 15478


Return to BSD News archive

Newsgroups: comp.os.386bsd.bugs
Path: sserve!newshost.anu.edu.au!munnari.oz.au!yoyo.aarnet.edu.au!news.adelaide.edu.au!basser.cs.su.oz.au!metro!news
From: dawes@physics.su.OZ.AU (David Dawes)
Subject: Re: Timezone nonsense
Message-ID: <1993May2.040825.6130@ucc.su.OZ.AU>
Sender: news@ucc.su.OZ.AU
Nntp-Posting-Host: physics.su.oz.au
Organization: School of Physics, University of Sydney, Australia
References: <C6CEJ3.8J@veda.is> <1runl4$f1r@wzv.win.tue.nl>
Date: Sun, 2 May 1993 04:08:25 GMT
Lines: 43

In article <1runl4$f1r@wzv.win.tue.nl> guido@gvr.win.tue.nl (Guido van Rooij) writes:
>adam@veda.is (Adam David) writes:
>
>>-DTIMEZONE=0 -DDST=0
>
>>/etc/localtime --> /usr/share/zoneinfo/GMT0
>
>>Around two days ago (probably corresponding to the start of DST somewhere)
>>the system clock lost an hour, as if it were subject to DST. The BIOS time
>>is on GMT, but 'date' is one hour earlier and still claims to be GMT.
>
>>Aaargh! This is 0.1.2.3, wasn't this kind of behaviour already fixed?
>Same happened here. See my other posting and it happened after exactly
>199 days in the year. It is due to the (in my opinion) incorrect patch
 ^^^
 119

>for clock.c (the first patch on this file). Incoreect because it leaves
>us with 2 different places where dst is handled, and even in a different
>way. Just uninstall this patch will do.

Seems to me that this bit of code in clock.c should only be used if
DST!=0, and you only set DST!=0 if your BIOS/RTC is making its own
DST adjustment.  I don't know if that code actually works with a BIOS
that does its own DST correction or not (mine doesn't do it).

Anyway, what I've done is to enclose the code in

  if (tz.tz_dsttime) { ... }


>>adam@veda.is
>
>-Guido

David
--
------------------------------------------------------------------------------
 David Dawes <dawes@physics.su.oz.au>    DoD#210      | Phone: +61 2 692 2639
 School of Physics, University of Sydney, Australia   | Fax:   +61 2 660 2903
------------------------------------------------------------------------------
 I was so satisfied, deep down inside, like a hand in a velvet glove -- AC/DC
------------------------------------------------------------------------------